Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Glances (Core) and Glances (WebUI) in two seperated repositories/packages #2114

Open
3 of 7 tasks
nicolargo opened this issue Aug 28, 2022 · 3 comments
Open
3 of 7 tasks

Comments

@nicolargo
Copy link
Owner

nicolargo commented Aug 28, 2022

For the moment (3.2.7), the Glances core functions and Glances WebUI are shipped in one package (pip install glances). The goal of this feature request is two split its in two seprated git repository/pypi package:

  • glances: the Glances core without WebUI
  • glances-webui: all the statics files for the Glances WebUI

Why ?

  • the WebUI is based on front-end technologies (AngularJS for the moment) and Glances core on pure Python
  • It will allow to have a dedicated team/maintainer for the Glances WebUI
  • Security issue and licensing management

How ?

  • Create a glances-webui git repository ==> https://github.com/nicolargo/glances-webui
  • Create a CI (Github Action) to build automatically the WebUI
  • Copy the content of the glances/outputs/static folder inside the glances-webui repository
  • Create a glances-webui pypi package (with a dep to glances)
  • Create a new GlancesWebUI Python class in order to manage the WebUI inside Glances "core". This class will provide the path for self.STATIC_PATH and TEMPLATE_PATH for glances_restfull.py (see Please add a startup flag to select an alternate web server static file path Please add a startup flag to select an alternate web server static file path #2612)
  • When the glances-webui is ready, remove all the glances/outputs/static (and the deps, Makefile...) from Glances
  • Identify the Glances version where the migration will be done => Glances 4.0.0
@RazCrimson
Copy link
Collaborator

@nicolargo
I think we should get this done first.
As this would decouple the web UI and the glances development.

Also would remove the need for this repo to contain node packages.

Another thing to do is, we should probably let the CI Pipeline to perform builds rather than us manually doing it and have such a build test on PRs to get visibility on if a npm package upgrade can break things in the UI.

@nicolargo
Copy link
Owner Author

I have made some change on the "How ?" section.

Copy link

github-actions bot commented Jul 8, 2024

This issue is stale because it has been open for 3 months with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants