Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavenization, junit 4.12 is added, some refactoring. #11

Merged
merged 5 commits into from
Mar 29, 2021

Conversation

ravingbool
Copy link

No description provided.

@ravingbool
Copy link
Author

Please create a public repo called https://github.com/nicolas-raoul/OSSRH-65862 to verify github account ownership.
It is needed due to https://issues.sonatype.org/browse/OSSRH-65862

@ravingbool
Copy link
Author

can I add some special symbols translation to KanaToRomaji.java?
aMap.put("「", """);
aMap.put("」", """);
aMap.put("。", ".");

Copy link
Owner

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing that!
It compiles fine but I noticed minor problems in the script and documentation, would you mind fixing it, so that I can merge?
Cheers :-)

README.md Outdated
```
java jakaroma-1.0-SNAPSHOT-jar-with-dependencies.jar -jar 六本木ヒルズ森タワー
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be java -jar target/jakaroma-1.0.0-SNAPSHOT-jar-with-dependencies.jar 六本木ヒルズ森タワー instead? Notice the target folder and 1.0.0 version number.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

jakaroma.sh Outdated
@@ -2,4 +2,4 @@

STRING=$1

java -Dfile.encoding=UTF-8 -cp lib/kuromoji-core-1.0-SNAPSHOT.jar:lib/kuromoji-ipadic-1.0-SNAPSHOT.jar:classes fr.free.nrw.jakaroma.Jakaroma $1
java -Dfile.encoding=UTF-8 jakaroma-1.0-SNAPSHOT-jar-with-dependencies.jar -jar $1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same (target and version number)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ravingbool
Copy link
Author

Hello @nicolas-raoul please take a look again, I fixed the issues :)

@nicolas-raoul nicolas-raoul merged commit 083e2dd into nicolas-raoul:master Mar 29, 2021
@nicolas-raoul
Copy link
Owner

Thanks a lot!
Please do not hesitate to fix any other issue, also the unit tests probably need some maintenance :-)

@ravingbool
Copy link
Author

Thank you for the quick response @nicolas-raoul! Have a tice day!
Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants