-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mavenization, junit 4.12 is added, some refactoring. #11
Conversation
Please create a public repo called https://github.com/nicolas-raoul/OSSRH-65862 to verify github account ownership. |
can I add some special symbols translation to KanaToRomaji.java? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing that!
It compiles fine but I noticed minor problems in the script and documentation, would you mind fixing it, so that I can merge?
Cheers :-)
README.md
Outdated
``` | ||
java jakaroma-1.0-SNAPSHOT-jar-with-dependencies.jar -jar 六本木ヒルズ森タワー |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be java -jar target/jakaroma-1.0.0-SNAPSHOT-jar-with-dependencies.jar 六本木ヒルズ森タワー
instead? Notice the target
folder and 1.0.0
version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
jakaroma.sh
Outdated
@@ -2,4 +2,4 @@ | |||
|
|||
STRING=$1 | |||
|
|||
java -Dfile.encoding=UTF-8 -cp lib/kuromoji-core-1.0-SNAPSHOT.jar:lib/kuromoji-ipadic-1.0-SNAPSHOT.jar:classes fr.free.nrw.jakaroma.Jakaroma $1 | |||
java -Dfile.encoding=UTF-8 jakaroma-1.0-SNAPSHOT-jar-with-dependencies.jar -jar $1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same (target
and version number)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Hello @nicolas-raoul please take a look again, I fixed the issues :) |
Thanks a lot! |
Thank you for the quick response @nicolas-raoul! Have a tice day! |
No description provided.