reduce and reduceRight support other accumulator types, fix #10 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me, I merged it and will make a new release. |
|
Version 1.1.3 was released with that fix. Thank you for your contribution. |
Very happy to contribute, you've developed a really great package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request add, improve or fixes?
Fixes #10
Can you explain why this improvement or fix may be useful?
As discussed in the issue. Note that the solution involves overloading the
reduceandreduceRightdefinitions to have versions that don't include aninitialvalue. This matches with the way it's done in the TypeScript definitions for the nativereduceandreduceRightIf you changed the code, have you added enough unit tests?
This is a TypeScript definitions fix, so there's no tests to add