Skip to content

Various fix for 2.2.5, including a memory corruption with 5.6.0-dev #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 20, 2014
Merged

Various fix for 2.2.5, including a memory corruption with 5.6.0-dev #447

merged 7 commits into from
Mar 20, 2014

Conversation

remicollet
Copy link
Collaborator

No description provided.

@remicollet
Copy link
Collaborator Author

With all of this.

Build with -Wall option : Ok, no warning.

$ php -v
PHP 5.6.0-dev (cli) (built: Mar 17 2014 07:56:15) 
$ php -n -dextension=modules/redis.so tests/TestRedis.php ; echo $?
Note: these tests might take up to a minute. Don't worry :-)
...............................................................S.....................................
Skipped test: /work/GIT/phpredis/tests/TestRedis.php:1869 (testWait) 
All tests passed.
0

@remicollet remicollet changed the title add tests to pecl package, fixed #332 Various fix for 2.2.5, including a memory corruption with 5.6.0-dev Mar 20, 2014
@michael-grunder
Copy link
Member

Remi, this is brilliant. I'll get it merged today!

Cheers,
Mike

@remicollet
Copy link
Collaborator Author

This is now documented
See http://git.php.net/?p=php-src.git;a=commitdiff;h=7f7c84d64f2cb6a1d8ac84d15788310eac580289

@michael-grunder michael-grunder merged commit b9a16b5 into phpredis:master Mar 20, 2014
@michael-grunder
Copy link
Member

Thanks dude, merged!

@remicollet remicollet deleted the issue-225 branch March 21, 2014 06:41
carlwgeorge pushed a commit to iuscommunity-pkg/php70u-pecl-redis that referenced this pull request Jun 13, 2016
- add numerical prefix to extension configuration file
afc01f2 
- add comment about session configuration
- fix memory corruption with PHP 5.6 phpredis/phpredis#447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @michael-grunder