update pivot.cofee(extra null check added to avoid error in case there is no filter data)

[gparida1989]

extra null check added to avoid error in case there is no filter data

[gparida1989]

Hi @nicolaskruchten ,

Is there any issue with validating the PR?

Regards

[nicolaskruchten]

Yep, the issue is that I don't have a ton of time to review PRs :) Please be patient!

Can you explain to me under what circumstances it's possible to hit the lines of code you're modifying and for filter to be undefined? This has never happened to me before so I'm not clear on how it's possible.

[gparida1989]

this occurs when I change my aggregate value to be used the aggregator and my filters are not changed .
so $(this).data("filter"); return null and the immediate line throws error.

[nicolaskruchten]

I’m afraid the example you’ve posted is too complex for me to follow. Can you provide a minimal reproducible example of the issue you’re trying to address?

…

On Thu, Nov 8, 2018 at 02:03 gparida1989 ***@***.***> wrote: this occurs when I change my aggregate value to be used the aggregator and my filters are not changed . so $(this).data("filter"); return null and the immediate line throws error. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1039 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMbA8-IbOCWgy4C-Xvx4EvevmidcuE9ks5us9degaJpZM4YLbfu> .