Including Google Pie Charts #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this contribution! I have very serious reservations about including this feature, as I mentioned in issue #66 because depending on the shape of the input you give, the pie chart output ends up being very wrong (i.e. Google Charts does a sum in an unintuitive way...). I would love some thoughts about how to support this in a safe/non-misleading way. |
|
Ahh, I see what you mean... Perhaps some logic like if the result set is only two rows and all of the data in the 2nd row don't result in NaN? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple addition, the only thing I can find missing from this repository at the moment!