Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuSentRelOpinionCollectionFormatter -- move all the opinion iteration during saving/loading into base class #141

Closed
nicolay-r opened this issue Jul 1, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jul 1, 2021

Logic become compex and hence some general aspects considered to be declared in base class.
Since formatter could save/load all the opinions or select only those which labels could be formatted, there is a need to perform the related refactoring

class RuSentRelOpinionCollectionFormatter(OpinionCollectionsFormatter):

This issue proceeds the #139 and the related bug #137

@nicolay-r nicolay-r added the enhancement New feature or request label Jul 1, 2021
@nicolay-r nicolay-r self-assigned this Jul 1, 2021
@nicolay-r nicolay-r changed the title RuSentRelOpinionCollectionsFormatter -- move all the opinion iteration during saving/loading into base class RuSentRelOpinionCollectionFormatter -- move all the opinion iteration during saving/loading into base class Jul 1, 2021
@nicolay-r
Copy link
Owner Author

Splited onto provider and writer parts, where provider also depends on the opinion converter (string -> Opinion type). See #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant