Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExperimentSerializationContext -- some parameters might be optional [Remove them] #369

Closed
nicolay-r opened this issue Jul 14, 2022 · 1 comment
Closed

ExperimentSerializationContext -- some parameters might be optional [Remove them] #369

nicolay-r opened this issue Jul 14, 2022 · 1 comment
Assignees
@nicolay-r
Labels
enhancement New feature or request

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Jul 14, 2022 •
edited
Loading

These parameters might not be required in BERT.

AREkit/arekit/common/experiment/api/ctx_serialization.py

Lines 26 to 32 in 8457797

@property
def FramesConnotationProvider(self):
raise NotImplementedError()
@property
def FrameVariantCollection(self):
raise NotImplementedError()

@nicolay-r nicolay-r added the enhancement New feature or request label Jul 14, 2022
@nicolay-r nicolay-r self-assigned this Jul 14, 2022
@nicolay-r
Copy link
Owner Author

nicolay-r commented Jul 15, 2022 •
edited
Loading

Already moved and refactored. e0f3faa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r