Allow to use mbrola binary installed in OS #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 10, 2021 16:33
- Kotlin 1.2 is not supported anymore by IntelliJ - Override default Java version of 1.8 so IntelliJ handles JPMS correctly - Define module.name property because parent POM requires it (actually this is not needed as we have proper module-info.java specs which define the module name) - Move MbrolaTest into another package because the same package cannot be used in different modules (IntelliJ complains)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Linux binary doesn't seem to work on recent Linux distributions anymore. This PR uses the mbrola version installed in the OS if the the platform specific mbrola-jvm-* module is not present in classpath.
Using mbrola installed in OS has become much easier with Docker and is more future proof.