Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS model #70

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Add DNS model #70

merged 1 commit into from
Sep 13, 2021

Conversation

miyuush
Copy link
Contributor

@miyuush miyuush commented Aug 31, 2021 •
edited by fuku2014
Loading

Summary

  • Support model json for DNS

Test

  • 以下のコマンドを実行して、DNSの箇所のテストがパスすることを確認
docker-compose run --rm app pipenv run test
  • 以下のコマンドのように DNSの機能を実行して問題なく動作できることを確認
PYTHONPATH=. python scripts/nifcloud-debugcli dns list-hosted-zones

@miyuush miyuush force-pushed the feature/add-dns-model-json branch 4 times, most recently from 271e3c8 to 6b46138 Compare September 13, 2021 08:43
@fuku2014
Copy link
Member

LGTM
image

@fuku2014 fuku2014 merged commit 333cd4f into main Sep 13, 2021
@fuku2014 fuku2014 deleted the feature/add-dns-model-json branch September 13, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuku2014 fuku2014 fuku2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miyuush @fuku2014