Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parser.py unittests(ess, dns) #81

Merged
merged 1 commit into from
Sep 14, 2021
Merged

add parser.py unittests(ess, dns) #81

merged 1 commit into from
Sep 14, 2021

Conversation

o108minmin
Copy link
Contributor

@o108minmin o108minmin commented Sep 10, 2021 •
edited by miyuush
Loading

Summary

  • Add tests for parser (ess, dns).

Test

  • Run unittests
pipenv run unittest

@o108minmin o108minmin self-assigned this Sep 10, 2021
miyuush
miyuush approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@miyuush miyuush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miyuush miyuush merged commit a72a7e2 into main Sep 14, 2021
@miyuush miyuush deleted the feature/add-test-parser-dns branch September 14, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miyuush miyuush miyuush approved these changes

Assignees

@o108minmin o108minmin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o108minmin @miyuush