-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for GlucoseDirect as CGM source #336
Comments
Glucose Direct supports 1min Libre2 values to be delivered into Trio, that is a valuable CGM information detail that could become usefull in the future. |
Can't we change the builtin then? We can change the submodules anyway |
@mountrcg @Sjoerd-Bo3 For Loop, these 1min updates caused a bunch of issues and drained pod batteries, i.e., failing devices, which is why it was limited to 5min. Also, it won't make much difference if you get your data based on 1 or 5 minute intervals based on interstitial glucose values. It's never real-time live blood glucose data. Basing this notion on various conversations I had at various conferences. Edit to add: Trio's submodules are hosted under the loopandlearn Github organization. We can diverge from LoopKit source code where necessary, but as laid out above, I would not change this to 1min intervals. |
I wouldnt discard 1min looping right away. Some AAPS users achieve great results with better safety. Sure there are things to overcome. I have a working version. The battery drain etc. will go down with time and Trio maturity and core data redesign. AutoISF on average loops in 5s on a 13mini, 1min intervall and the data amount increased that to around 13s - but Marvin and you Deniz will fix that. |
iOS is not Android, and the battery drain is the pod battery, not the phone battery, apologies if that was confusing in my earlier comment. |
The only pumps currently supported by Trio will not support 1 minute updates. It is even more of a problem for Medtronic than for pods. If in future, the Trio code is modified to accept 1 minute updates as part of the decision making with a limit to send pump commands no more frequently than 5 minutes (perhaps limited by pump type - but that is what is reasonable for Medtronic and pod pumps). I know some people complained that they wanted to see the 1 minute data. If GD were under active development, I don't think we'd be having this conversation.
|
GD offers support for Libre3. |
xDrip4iOS can now be used for Libre3 as well. |
And xDrip4iOS is actually being maintained. GlucoseDirect is stale repo for 2 years already |
nightscout#336 resolutions
hey 👋 - no triage is done for 30 days 🤐 ... anybody? triage is required! |
I think there is agreement that we should remove support for GD. I changed the labels to avoid this issue getting stale. |
Addressed in TCD / Trio 1.0.0-dev. |
Is your feature request related to a problem?
We are expecting to make a breaking change for GlucoseDirect (GD) with the goal of improving the data sharing between Trio and xDrip4iOS (see #313). This includes creating a new shared app group that is different from the one used by Loop and iAPS.
I don’t think GD does anything Xdrip doesn’t, now that the online libre option is available there. If this is accurate, I suggest we just remove GD support, as it appears to not being maintained, and there are other options available.
Describe the solution you'd like
Remove support for GlucoseDirect as CGM source, as we would otherwise have to take on support for another app.
Describe alternatives you've considered
No viable alternatives unless someone steps up to maintain GD.
User Impact
Current GD users, if any, would have to transition to xDrip4iOS.
The text was updated successfully, but these errors were encountered: