Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAGE uploads in NS for Libre Transmitter #112

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

avouspierre
Copy link
Contributor

Fix issue #108
The implementation is not perfect because need to add LibreTransmitter library in OiAPS.

Should be tested by @kylmcw

Fix issue #108
The implementation is not perfect because need to add LibreTransmitter library in OiAPS
@avouspierre avouspierre requested a review from kylmcw April 15, 2024 12:05
@bjornoleh
Copy link
Contributor

Fix issue #108 The implementation is not perfect because need to add LibreTransmitter library in OiAPS.

Should be tested by @kylmcw

I suppose this is an acceptable solution if it works as intended? What are the drawbacks of adding the LibreTransmitter library in OiAPS?

@avouspierre
Copy link
Contributor Author

The beauty of the code 😂.

More seriously, the correct pattern should be to use only the generic protocol (here cgmManager defined in Loopkit) and not a specific implementation of cgmManager (here Libre). That requires to modify Loopkit protocol... probably a long journey to integrate the sensor information in the protocol. The cons : if Libre changes, requires to update the code... that's why protocol exists.. https://guilhermemello1988.medium.com/swift-protocols-delegate-and-notification-design-patterns-b9ce13b601da

@bjornoleh
Copy link
Contributor

Merging into alpha for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants