Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.2.1 - Hotfix for main: Update Gemfile.lock for Fastlane 2.223.1 #419

Merged
merged 2 commits into from
Sep 29, 2024
Merged

v0.2.1 - Hotfix for main: Update Gemfile.lock for Fastlane 2.223.1 #419

merged 2 commits into from
Sep 29, 2024

Conversation

MikePlante1
Copy link
Contributor

@MikePlante1 MikePlante1 commented Sep 28, 2024 •
edited by dnzxy
Loading

Update main branch for Fastlane 2.223.1
This fixes a new TestFlight build problem with this error message

Found more than 1 matching build

This is an issue on Apple's side
Here is the fastlane Issue:

Here is an example of a failed Trio build, which is fixed with 2.223.1

Matching PR for dev can be found at:

Addresses and resolves issue #422.

@MikePlante1 MikePlante1 mentioned this pull request Sep 28, 2024
Merged
Sjoerd-Bo3
Sjoerd-Bo3 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@Sjoerd-Bo3 Sjoerd-Bo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged in my own repo, builds.

bjornoleh
bjornoleh approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed to fix the build error.

marionbarker
marionbarker approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this Gemfile.lock on LoopWorkspace, LoopFollow, LoopCaregiver.
Code review indicates a good PR for Trio.

@dnzxy
Copy link
Contributor

dnzxy commented Sep 29, 2024

Merging with 5 approvals. Thank you everyone. Will be released as Trio version 0.2.1.

@dnzxy dnzxy merged commit 2e86678 into nightscout:main Sep 29, 2024
1 check passed
@dnzxy dnzxy mentioned this pull request Sep 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornoleh bjornoleh bjornoleh approved these changes

@dnzxy dnzxy dnzxy approved these changes

@marionbarker marionbarker marionbarker approved these changes

@Sjoerd-Bo3 Sjoerd-Bo3 Sjoerd-Bo3 approved these changes

@AndreasStokholm AndreasStokholm AndreasStokholm approved these changes

@aug0211 aug0211 Awaiting requested review from aug0211 aug0211 is a code owner

@t1dude t1dude Awaiting requested review from t1dude t1dude is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MikePlante1 @dnzxy @AndreasStokholm @Sjoerd-Bo3 @marionbarker @bjornoleh