Test hangs

[naissa12]

I have a suite of tests. Sometimes, one of the test hangs. It seems like it is not getting a response from selenium. Is there better error handling that can be added when this happens so that the test can retry? Right now it hangs and doesn't retry. It's one test out of the full suite that hangs.

[NickStefan]

Same problem. We need to add a timeout and retry logic to the actual http request between nightwatch and selenium. Setting the page load timeout on seleneium, in a before each, does not work:

browser.timeouts('page load', 30000)

because the "hanging" sometimes happens before even that "before" code runs. This pointed me to go look at the HTTP logic here. There's no timeout or retry logic in the http module of this library.

[NickStefan]

So I think this is actually more related to this: #470

I monkey patched nightwatch/libs/http/request.js to listen for the timeout event:

self.request.setTimeout(30000, function(){
    console.log('timeout');
     self.emit('error', {});
})

Sure enough, every time our tests had been merely hanging before, this was triggered. Only now, with the error tigger, it helped surface that the selenium server had basically died on the CI server.

I still dont have a solution for selenium server randomly falling over...

[NickStefan]

Now I'm not so sure. Doing health check against the selenium server and it continues to respond to curl requests even when a random test has a timeout

[beatfactor]

Fixed as part of #1232.