Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce stricter integer parsing on encode function #24

Merged
merged 2 commits into from
Aug 29, 2016
Merged

Enforce stricter integer parsing on encode function #24

merged 2 commits into from
Aug 29, 2016

Commits on Aug 28, 2016

  1. Add test for encode preceding integer failure

    @ebramanti
    ebramanti committed Aug 28, 2016
    Configuration menu
    Copy the full SHA
    fc03be6 View commit details
    Browse the repository at this point in the history

  2. Enforce stricter integer parsing with filterInt 

    filterInt enforces that the value to be encoded is indeed an integer.

From parseInt documentation on MDN:

> If parseInt encounters a character that is not a numeral in the
specified radix, it ignores it and all succeeding characters and
returns the integer value parsed up to that point.

See more here:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global
_Objects/parseInt
    @ebramanti
    ebramanti committed Aug 28, 2016
    Configuration menu
    Copy the full SHA
    0036859 View commit details
    Browse the repository at this point in the history