Symfony 5.x support

[kiettran]

This pull request adds full symfony 5 support. Do note, this pull request does not have symfony 3.4 or symfony 4.x support anymore.

#23

[xvilo]

@kiettran any idea on when you will finish this?

[kiettran]

It’s done except two tests are failing because the classes are final and cannot be mocked. The pull request does work within a symfony 5 project. I will have a look on the tests this week.

It's done.

[niels-nijens]

Thanks for the effort (again).

In its current form I'm unable approve this. Symfony 4.4 is supported until the end of 2022 and I'm unwilling to drop support for it when Symfony does not.

Though, I am willing to drop support for Symfony 3.4 to make the upgrade path easier.

A lot is going on in this pull request and it's not just Symfony 5.x support. It should only contain just that.

[niels-nijens]

Finally had some time to review in more detail. I still think it is possible to support all three currently maintained Symfony versions.

[niels-nijens]

By changing to the following, it's made compatible with both Symfony 3.4 and 4.4/5.1 (including the above suggestions):

Suggested change

	public function validateRequestBody(RequestEvent $event): void
	public function validateRequestBody($event): void

[niels-nijens]

I noticed after my review that the change of type hints in the RouteLoader might be the only backwards compatibility problem.

For this I tried the following changes:
master...niels-nijens:route-loader-type-hints

Although it's not the prettiest code, it works like a charm. 😄

When you rebase to master and possibly fix the conflicts, I can PR it to your branch.

If you need any help getting this ready. Let me know!

[niels-nijens]

Thanks!