Expose the regexp / url matched the route #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xepozz thanks for your patch and sorry for the conflicts, they're related to the introduction of the result objects... I've tried a different approach to solve both unparsed regex exposure and the ability to add custom extra parameters on #269. The performance impact is making me hesitant, though. I'd appreciate your thoughts there. |
|
Replaced by #269. |
|
@lcobucci It's not a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially covers #225 and hypothetically could be covered fully is parser will return both raw and encoded route string.
I'm not sure about the full covering way, but hope at least this changes could help