Feature add a builder for interface #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| eval($this->dump($contract)); | ||
|
|
||
| $this->assertTrue(interface_exists('Contract', false)); |
There was a problem hiding this comment.
Perhaps more tests here would be nice on the constant...
|
Thanks, committed in 12faad5 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I like your design of the fluent builders. Though a builder for interfaces would be nice.
I try to closely following your formatting and coding conventions. If something is wrong, don't hesitate to criticize.
You can find in this PR :
Hope this helps 馃嵑
PS: one other thing I forgot :
There is some copy-paste between class builder and interface builder but I don't think we can factorize both builders. It reminds me the circle-ellipse problem.