Make slice() breaks immediately after last value #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Nov 29, 2018
| @@ -487,13 +487,13 @@ function slice(iterable $iterable, int $start, $length = INF): \Iterator { | |||
|
|
|||
There was a problem hiding this comment.
We'll now need a check for zero length here and abort early in that case.
There was a problem hiding this comment.
Though that will also change behavior in that it will no longer consume the first $start elements of the iterator. Not sure if that's important...
There was a problem hiding this comment.
I've added check for zero length.
And you are right - it will no longer run iterator in that case.
I don't know if that's ok or not. I've never used zero length for slicing.. (at least not intentionally)
nikic
reviewed
Nov 29, 2018
|
Merged as 956ff19. Sorry for the long delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #75