Remove node that are in one line

[kl3sk]

Hello,

I want to remove node (Trait1 only in this example) if they are like this

class MyClass {
     use Trait1, Trait2;
}

My node visitor in leaveNode return an array of Node\Name.

public function leaveNode(Node $node)
{
    if ($node instanceof Node\Stmt\TraitUse) {
        $node->traits; // list of trait
    }
}

With many tries, I only archived to have (for example):

use , Trait2; or even worst use ;

Thank for you help

[nikic]

Could you share the actual code you're using in leaveNode()? Also, are you using the formatting-preserving pretty printer?

[kl3sk]

Hello,

I didn't have the same behaviour, but I play around this:

        if ($node instanceof Node\Stmt\TraitUse) {
            $searched = $this->getTrait();

            if ($this->getMode() === 'remove') {
                foreach ($node->traits as $index => $trait) {
                    if (\in_array($searched, $trait->parts)) {
                        unset($node->traits[$index]);
                        // return NodeTraverser::REMOVE_NODE;
                    }
                }
            } else {
                foreach ($node->traits as $trait) {
                    if (\in_array($searched, $trait->parts)) {
                        $this->canAdd = false;
                    }
                }
            }
        }

Independently, with unset or NodeTraverser::REMOVE_NODE
and

use Trait1;
use Trait2;

or

use Trait1, Trait2;

Doesn't result to the same result.

Finally, I use the printFormatPreserving, with prettyPrintFile it doesn't have the same behaviour. Especially with the unset method.

[nikic]

I see. The problem is that the formatting-preserving printer assumes that arrays are lists (in the array_is_list sense), while unset() leaves behind a hole in the index sequence. This ends up completely breaking things (the Differ actually throws a notice).

It might make sense to handle this situation more gracefully.

[nikic]

Fixed by 289756d.