Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a changelog #20

Open
jletey opened this issue Feb 18, 2019 · 14 comments
Open

Add a changelog #20

jletey opened this issue Feb 18, 2019 · 14 comments

Comments

@jletey
Copy link
Contributor

jletey commented Feb 18, 2019

We should definitely use https://github.com/yoshuawuyts/changelog

@jletey jletey changed the title Changelog Add a changelog Feb 19, 2019
@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

@nikitavoloboev Are we ready for a version 1.0.0 release ... there is still some open issues, but I feel like we have a core product down

Plus, the command line tool already says that we're on version 1.0.0

@nikitavoloboev
Copy link
Owner

Agreed, let's release

@nikitavoloboev
Copy link
Owner

I am not sure the process of releases is, I think pushing code to github is currently the way people do that.

Then go get .. gets the latest version. We should just add a changelog and Git tag releases I think.

@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

We should just add a changelog and Git tag releases I think.

I agree ... the Git tag will probably have to come first (which I don't think I'll be able to do) nikitavoloboev/markdown-parser#14 (comment)

@nikitavoloboev
Copy link
Owner

I made a tag & pushed it https://github.com/nikitavoloboev/license-up/releases

Not sure if this is what what was needed. I will read the rust changelog tool readme again.

@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

Not sure if this is what what was needed.

I'm still getting the same error

@nikitavoloboev
Copy link
Owner

Ok will try solve

@jletey
Copy link
Contributor Author

jletey commented Feb 25, 2019

It turns out that you can't create a changelog without details in a Cargo.toml ... I've submitted a feature request (yoshuawuyts/changelog#25)

@jletey
Copy link
Contributor Author

jletey commented Feb 25, 2019

@nikitavoloboev Could you rename the latest release tag from v1.0 to 1.0.0 ... this is what we have as the version in the cli, and plus this looks better when the changelog is generated

Do you want me to generate a changelog now (without pushing the Cargo.toml) or wait until the above feature request gets implemented?

@nikitavoloboev
Copy link
Owner

Id wait until your issue gets addressed. In the meanwhile we can look for another changelog generator that is good?

@jletey
Copy link
Contributor Author

jletey commented Feb 25, 2019

Sounds good!

@jletey
Copy link
Contributor Author

jletey commented Feb 25, 2019

How about Github Changelog Generator? It looks pretty nice and we can have Travis run it every time we push something ... the only downside is that it doesn't include commits (only issues and PRs)

@nikitavoloboev
Copy link
Owner

Not too fond of it. Lets wait for what the dev of rust changelog answers.

@jletey
Copy link
Contributor Author

jletey commented Feb 25, 2019

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants