Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Dockerfile #26

Closed
wants to merge 1 commit into from
Closed

Adds Dockerfile #26

wants to merge 1 commit into from

Conversation

adamdougal
Copy link

Also adds the IntelliJ folder to .gitignore.

Required by #25

Also adds the IntelliJ folder to `.gitignore`.

Required by #25
@adamdougal adamdougal mentioned this pull request Jun 25, 2019
@nikku
Copy link
Owner

nikku commented Jun 27, 2019

Thanks for the PR.

So, what is the purpose of this docker file?

  • simple try out
  • simple run in production
  • anything else?

@adamdougal
Copy link
Author

We're currently deploying this to our Kubernetes cluster. To be able to do that we have to clone your repo and build it as a Docker image. Having this in the main Wuffle repo saves us and anyone else from having to create our own Docker image.

The next ideal step would be for this to be published to https://hub.docker.com/ as that would then save us from having to clone this repo to get the Docker image.

@nikku
Copy link
Owner

nikku commented Jul 3, 2019

Thanks for your contribution. A few quick things:

  • for building the image and distribution we should use the builder pattern: one image to build the app and another one to copy / install only the production dependencies to
  • we must install and build the client, otherwise the resulting app will not be usable. I do not see how your script does that
  • It probably makes sense to build and run using alpine images (smaller footprint, download and install)

Do you have any idea how publishing to docker hub works?

@nikku
Copy link
Owner

nikku commented Jul 4, 2019

Figured out publishing to docker hub.

Pre-built images will be available via nrehwaldt/wuffle:{latest|next}.

Added a docker file that circumvents the problems mentioned above: https://github.com/nikku/wuffle/tree/master/support/docker

@nikku nikku closed this Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants