Fix ligatures when letter-rendering#1085
Open
eKoopmans wants to merge 2 commits intoniklasvh:masterfrom
Open
Conversation
eKoopmans
force-pushed
the
bugfix/ligatures
branch
from
7644a3b to
a6a5e3a
Compare
niklasvh
force-pushed
the
master
branch
3 times, most recently
from
932773c to
1584357
Compare
Contributor
Author
|
Tested, this is still an issue in v1.0.0-a1 (using non-foreignObjectRendering). I can work out a fix for the latest build if you like. |
|
The "f" and "l" are overlapping.
Is there going to be a fix soon? |
|
Hi, i tried using the fix from 838 Is there gonna be an update soon that fixes this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Ligatures
Text is sometimes rendered incorrectly, when the font uses ligatures and the text is rendered letter-by-letter. Adjacent letters (i.e. 'fi') are rendered on-top of each other.
Fix
When text is being rendered per-character (instead of per-word), this fix adds the
font-variant-ligatures: noneCSS to the parent element. There is also a fix to the.font()handling offont-variantCSS data, as not allfont-variantvalues are supported on canvases.Related issues/pull requests
#838