Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ligatures when letter-rendering #1085

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@eKoopmans
Copy link
Contributor

@eKoopmans eKoopmans commented Mar 26, 2017

Bug: Ligatures

Text is sometimes rendered incorrectly, when the font uses ligatures and the text is rendered letter-by-letter. Adjacent letters (i.e. 'fi') are rendered on-top of each other.

bugfix-ligatures

Fix

When text is being rendered per-character (instead of per-word), this fix adds the font-variant-ligatures: none CSS to the parent element. There is also a fix to the .font() handling of font-variant CSS data, as not all font-variant values are supported on canvases.

Related issues/pull requests

#838

@eKoopmans eKoopmans force-pushed the bugfix/ligatures branch from 7644a3b to a6a5e3a Mar 27, 2017
@niklasvh niklasvh added this to Backlog in Backlog Jul 27, 2017
@niklasvh niklasvh force-pushed the master branch 3 times, most recently from 932773c to 1584357 Dec 3, 2017
@eKoopmans
Copy link
Contributor Author

@eKoopmans eKoopmans commented Dec 6, 2017

Tested, this is still an issue in v1.0.0-a1 (using non-foreignObjectRendering). I can work out a fix for the latest build if you like.

@Mylogin-info
Copy link

@Mylogin-info Mylogin-info commented Apr 27, 2018

The "f" and "l" are overlapping.

overlap

Is there going to be a fix soon?

@weestack
Copy link

@weestack weestack commented May 7, 2018

Hi, i tried using the fix from 838
but with no success.
Using version v1.0.0-alpha.12

Is there gonna be an update soon that fixes this?
5af06bf90fd14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants