Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove konf.Logger in favor of slog #48

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Remove konf.Logger in favor of slog #48

merged 2 commits into from
Nov 11, 2023

Conversation

ktong
Copy link
Collaborator

@ktong ktong commented Nov 11, 2023

No description provided.

@ktong ktong changed the title use slog Remove konf.Logger in favor of slog Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #48 (89f4d0d) into main (a25863b) will decrease coverage by 0.83%.
The diff coverage is 66.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   77.88%   77.06%   -0.83%     
==========================================
  Files          16       15       -1     
  Lines         615      593      -22     
==========================================
- Hits          479      457      -22     
  Misses        127      127              
  Partials        9        9              
Components Coverage Δ
konf 92.28% <66.66%> (-0.39%) ⬇️
pflag 41.57% <ø> (ø)
Files Coverage Δ
config.go 97.63% <100.00%> (ø)
global.go 100.00% <100.00%> (ø)
option.go 100.00% <ø> (ø)
provider/file/file.go 100.00% <100.00%> (ø)
provider/file/watch.go 54.38% <25.00%> (ø)

@ktong ktong merged commit f0cdfba into main Nov 11, 2023
12 of 15 checks passed
@ktong ktong deleted the kt_log branch November 11, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant