Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues #33

Merged
merged 5 commits into from
Jan 14, 2016
Merged

Fix some issues #33

merged 5 commits into from
Jan 14, 2016

Conversation

yurilaaziz
Copy link
Contributor

I need more time to understand the architecture.
some fix to old bugs :D

@yurilaaziz yurilaaziz changed the title Architecture Fix some issues Jan 9, 2016
@nil0x42
Copy link
Owner

nil0x42 commented Jan 10, 2016

Hi @yurilaaziz , thank you for the contributions.

As i am currently working hard on some stuff, i have no time to deeply test you features, do i d like to know if you tested each one of them.

Also, i d like to know in which case the following commit: yurilaaziz@3c5f2ae fixes a bug. We need to be very careful about potential side effects, as i never deployed a test suite mechanism for phpsploit (my greatest mistake)

The changelog is very very unreliable, as i did something like 100 commits without updating it (to be honnest, you just remembered me the existence of this file haha)

I'll do some tests, and merge it soon. Great job !

@yurilaaziz
Copy link
Contributor Author

yes I test it also I run the test script !
open(w) opens file with write mode without creation if it's not exist. I added the w+ to generate the HTML phpinfo file (phpinfo --browse)

take your time, and I am working on the project in my free time !

nil0x42 added a commit that referenced this pull request Jan 14, 2016
@nil0x42 nil0x42 merged commit 2e7efbd into nil0x42:master Jan 14, 2016
@nil0x42
Copy link
Owner

nil0x42 commented Jan 14, 2016

@yurilaaziz as i have a lot of work, i merged your pull request.
therefore, after trying it a saw that you forget to update phpinfo command's docstring (which is used by the framework when you type help phpinfo.
so i will update it, but keep in mind that plugin docstring might be updated when a functionnality is added to the framework :)

I updated the docstring in commit: ea46b7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants