Fix: e-mail attachments problems #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based (but adapted and improved) on my old changes at sourceforge: @see: https://sourceforge.net/u/cbello/netimplicitssl/ci/3d8ac39620390e9ff7f8c1fbaf1ab55f2d94fc4f/ I was asked to make a pull request of my changes, but I'm never did it. Sorry. - Small fixes in e-mail attachment headers. - Used attachment.name property instead of FileName for set the attachment name. - Now we can use ignored property NameEncoding for set encoding of the attachment name. - Refactor constructors of MimeAttachment class. Note: ContentType property it's initialized in the base class constructors and should not be reassigned. With these changes, works in the similar way as the original System.Net.Mail does and fix nilnull#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based (but adapted and improved) on my old changes at sourceforge:
@see: https://sourceforge.net/u/cbello/netimplicitssl/ci/3d8ac39620390e9ff7f8c1fbaf1ab55f2d94fc4f/
I was asked to make a pull request of my changes, but I'm never did it.
Sorry.
attachment name.
attachment name.
property it's initialized in the base class constructors and should not
be reassigned.
With these changes, works in the similar way as the original
System.Net.Mail does and fix #6