Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes and features #32

Closed
wants to merge 6 commits into from
Closed

Conversation

carlosbet
Copy link
Contributor

With these changes, can be fixed documented issues and also add support for XOauth2 and OAuthbearer (RFC 7628) authentication methods.

Based (but adapted and improved) on my old changes at sourceforge:
@see: https://sourceforge.net/u/cbello/netimplicitssl/ci/3d8ac39620390e9ff7f8c1fbaf1ab55f2d94fc4f/

I was asked to make a pull request of my changes, but I'm never did it.
Sorry.

- Small fixes in e-mail attachment headers.
- Used attachment.name property instead of FileName for set the
attachment name.
- Now we can use ignored property NameEncoding for set encoding of the
attachment name.
- Refactor constructors of MimeAttachment class. Note: ContentType
property it's initialized in the base class constructors and should not
be reassigned.

With these changes, works in the similar way as the original
System.Net.Mail does and fix nilnull#6
In the last times, some popular email providers such for example Gmail,
Microsoft/Office 365 and others disables normal user and password login
and “forces” using XOauth2 or OAuthbearer authenticating methods based
in tokens.
Now this auth methods are supported. For OAuthbearer implements the
standard defined in RFC 7628.
@see: https://datatracker.ietf.org/doc/html/rfc7628
Added a valid Message-ID header using an GUID and the host.

Other possible headers added by user to `MailMessage.Headers`
collection are processed.

Fixes nilnull#33 issue
@carlosbet carlosbet closed this Sep 9, 2022
@psikola
Copy link
Contributor

psikola commented Oct 7, 2022

Hi, any info about merging into master ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants