Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird idetools column misplacements #416

Closed
gradha opened this issue May 3, 2013 · 4 comments
Closed

Weird idetools column misplacements #416

gradha opened this issue May 3, 2013 · 4 comments
Labels

Comments

@gradha
Copy link
Contributor

gradha commented May 3, 2013

Continuing my work on https://github.com/gradha/the_hyperlink_vs_nimrod/tree/develop I'm unleashing idetools on simple source files and finding unexpected results. If you take a look at http://dl.dropboxusercontent.com/u/145894/t/weird.proc.th.html you will see highlighted the characters for which idetools returns anything for the --def option.

In general it does a good job, but there are strange off by one errors. Many words are highlighted one character past their actual text, including whitespace. But more worrying is that on line 12 column 16 the first letter of the toSeq iterator is not highlighted, which seems a bug.

@gradha
Copy link
Contributor Author

gradha commented May 4, 2013

Further parsing of the idetools output to display the docstrings highlights that the last call to test() on line 17 produces an incorrect docstring for the local proc, for some reason it gets the docstring from the runes() iterator.

@gradha
Copy link
Contributor Author

gradha commented May 6, 2013

Since dropbox sucks I've mirrored the file at https://gist.github.com/gradha/5528425, though gist is not very user friendly for HTML either.

@Araq
Copy link
Member

Araq commented Sep 11, 2013

Column handling has been fixed in the compiler by now.

@Araq Araq closed this as completed Sep 11, 2013
@gradha
Copy link
Contributor Author

gradha commented Sep 23, 2013

It seems to be a little better but not yet correct. I've updated http://dl.dropboxusercontent.com/u/145894/t/weird.proc.th.html where you can see the toSeq doesn't get any love at all, and the exported input variable is shifted (though that's likely easier tracked in #452). You can also run the idetools test case which fails to verify the columns are ok:

    $ cd tests
    $ nimrod c -r caasdriver 416

reactormonk pushed a commit to reactormonk/nim that referenced this issue Apr 7, 2014
reactormonk pushed a commit to reactormonk/nim that referenced this issue Apr 7, 2014
Clyybber pushed a commit to Clyybber/Nim that referenced this issue Nov 7, 2022
416: cleanup: remove warnings throughout the compiler r=saem a=saem

## Summary

- mostly cleaning up unused variables and procs
- consolidated max macro pragma and generic instantiation const

Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants