deprecate += and friends for bool and enum #10336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushalmodi
reviewed
Jan 16, 2019
lib/system.nim
Outdated
| magic: "Dec", noSideEffect.} | ||
| ## Decrements an ordinal | ||
|
|
||
| proc `*=`*[T: SomeOrdinal|uint|uint64](x: var T, y: T) {. | ||
| proc `-=`*[T: enum|bool](x: var T, y: T) {. | ||
| magic: "Dec", noSideEffect, deprecated: "use `dec` instead".} |
There was a problem hiding this comment.
I believe that the deprecation message should include the Nim version starting when that deprecation is effective. That would later help to batch remove deprecations.
If these deprecations are effective starting Nim 0.20, then it's easy to grep for version-specific deprecations and remove all in one go.
Very much related: nim-lang/RFCs#93
kaushalmodi
reviewed
Jan 16, 2019
|
|
||
| proc `-=`*[T: SomeOrdinal|uint|uint64](x: var T, y: T) {. | ||
| proc `+=`*[T: enum|bool](x: var T, y: T) {. | ||
| magic: "Inc", noSideEffect, deprecated: "use `inc` instead".} |
There was a problem hiding this comment.
Suggested change
| magic: "Inc", noSideEffect, deprecated: "use `inc` instead".} | |
| magic: "Inc", noSideEffect, deprecated: "0.20.0, use `inc` instead".} |
There was a problem hiding this comment.
@krux02 Looks like you didn't merge this suggested edit.
Co-Authored-By: krux02 <arne.doering@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*=never worked for bool, so didn't implement a deprecation path.fixes #10257