-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #12519: introduce OrderedTable.take, CountTable.del, CountTable.take #12600
Conversation
Needs the upcoming |
Done. |
No changelog entry? |
Done :) |
I realize this naming is patterned after the 2 year old Also, this operation is not really covered in (Less relevant than Nim-internal consistency, but Python also calls it My vote would be to name this |
(And of course there are also |
#12600 and in https://forum.nim-lang.org/t/5499 indicates that everyone is happy/happier with ``pop``. This just renames the brand new ``take``s to ``pop`` and installs inline aliases/wrappers to preserve ``Table.take`` and ``TableRef.take``. Update apis.rst to try to maintain consistency of remove-and-return procs.
Rationale: these procs exist for
Table
, they should also exist forOrderedTable
andCountTable
.Fixes #12519.