Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: hashes module doesn't compile with vcc #14149

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

cooldome
Copy link
Member

This is showstopper regression.
Code doesn't compile because _umul128 is in intrin.h and this header file is not included.

@Araq Araq merged commit 289d48e into devel Apr 28, 2020
@Araq Araq deleted the fix_hash_regression branch April 28, 2020 16:02
@Clyybber
Copy link
Contributor

cc @c-blake

@c-blake
Copy link
Contributor

c-blake commented Apr 28, 2020

How did the pre-fixing version pass the Azure CI? Does the Windows branch of that CI not use vcc for some reason? Is it a vcc version skew thing?

Anyway, the fix looks fine, but also are we sure that defined(windows) and not defined(tcc) is basically selecting vcc? Should the guard be defined(vcc) or maybe defined(windows) and defined(vcc) instead? A quick search in the whole Nim repo yields varying answers.

@ghost
Copy link

ghost commented Apr 28, 2020

@c-blake yeah, seems a bit wrong since you can have GCC (mingw), Clang on Windows too

@c-blake
Copy link
Contributor

c-blake commented Apr 28, 2020

Those should be (?) caught by the first elif defined(gcc) or defined(llvm_gcc) or defined(clang) and that __uint128_t fork should work ok (at least or recent versions...Not entirely sure when __uint128_t was introduced).

Anyway, it could definitely use some multi-compiler testing on Windows. I was never sure how much the CI tested, exactly.

@Araq
Copy link
Member

Araq commented Apr 29, 2020

@c-blake VCC isn't tested at all, unfortunately.

EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
Co-authored-by: cooldome <ariabushenko@bk.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants