followup #17561, skipping ci now implies green #17813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_17561_followup_skip_ci_green
branch
from
4b0c68b
to
0b18f3e
Compare
2 tasks
timotheecour
changed the title
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* followup nim-lang#17561, skip ci now implies green; [skip ci] * fixup [skip ci] * fixup test without skip ci * fixup [skip ci] * fixup2 [skip ci] * github actions now automatically supports [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows #17561
[skip ci]logic from github actions pipelines because github actions now supports this, see https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/[skip ci]now makes CI appear green, not red, which is more intuitive (eg intypeof(voidStmt)now works #17807, i added a changelog with a[skip ci]commit, it turned CI red which was undesirable); note that reviewers + authors must still understand semantics of[skip ci]and ensure that, wherever appropriate, a prior commit should have a non-skipped green CI in the general case