fix nimscript syntax check [backport: 1.6] #19444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
force-pushed
the
pr_configure
branch
from
a454cb6
to
963e00b
Compare
|
CI is broken because numericnim relies on an external dependency. |
|
nim check shouldn't run nimscript but that's a different issue. I'll push that fix later. More information at #8219 |
fix nim-lang#19440; fix nim-lang#3858 typo good for today reason
ringabout
force-pushed
the
pr_configure
branch
from
507e8c2
to
a5e5408
Compare
ringabout
changed the title
ringabout
changed the title
This was referenced Jan 26, 2022
|
ready for review |
narimiran
pushed a commit
that referenced
this pull request
Mar 24, 2022
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #19440; fix #3858