fix #19546 Missing compiler error for array in type definition (also …

[bung87]

…apply to seq, set)
fix #19546
fix #13992
fix #19164
fix #6982

related: #15993

[beef331]

As you're on the quest of fixing these issues, I will note that openarray, sink, and lent also compile without complaint.

[bung87]

As you're on the quest of fixing these issues, I will note that openarray, sink, and lent also compile without complaint.

could you provide example? that's may not related , here are fix for type declaration and variable declaration, types your provide are in proc arguments.

[beef331]

type A = object
  a: openarray
  b: sink
  c: lent

[bung87]

CI fails cause by https://github.com/SciNim/numericalnim/blob/614cb304d74ac32869ff74e0d013681ecf4ff5c8/src/numericalnim/integrate.nim#L420

suprised this syntax is used in real project.

const gaussWeights: array[1..20, (seq, seq)] = [
  (@[0.0],
  @[2.0]),

[bung87]

@beef331 told me proc doThing(a: seq, b: set, c: array) is valid , but I didnot consider that. no idea for now.

[metagn]

Maybe a simpler solution is just to put tyNone in tyTypeClasses/tyMetaTypes?

Or, if we want to error just for object fields, change t.isMetaType in checkForMetaFields to (t.isMetaType or t.kind == tyNone).

[bung87]

Maybe a simpler solution is just to put tyNone in tyTypeClasses/tyMetaTypes?

Or, if we want to error just for object fields, change t.isMetaType in checkForMetaFields to (t.isMetaType or t.kind == tyNone).

good idea, let's hear morevoice.

[dlesnoff]

Would it be possible, in case of a type definition, to add the field's name in the error message ?

[bung87]

Would it be possible, in case of a type definition, to add the field's name in the error message ?

it's possible. let's see @Araq 's opinion.

[dlesnoff]

Tested your code on some examples.

type
  myObject = object
    tab: seq

Now fails gracefully with a seq is not a concrete type. Thanks !

type
  myObject[T] = object
    tab: seq

Why does this not fail ?!

type
  someGeneric[T] = object
    field: seq
type
  myObject = object
    tab: someGeneric

Fails with someGeneric is not a concrete type. Should IMO fail at someGeneric type definition, just like previous example.

[dlesnoff]

Here is a currently problematic error description:

type
  someGeneric[U, V] = object
    a: seq[U]
    b: seq
  myObject = object
    tab: someGeneric[int, string]

got: ~/Documents/dev/typeGenericsIssue.nim(6, 5) Error: 'someGeneric' is not a concrete type
The error is not in tab's field but in field b of someGeneric type definition

[bung87]

Here is a currently problematic error description:

type
  someGeneric[U, V] = object
    a: seq[U]
    b: seq
  myObject = object
    tab: someGeneric[int, string]

got: ~/Documents/dev/typeGenericsIssue.nim(6, 5) Error: 'someGeneric' is not a concrete type The error is not in tab's field but in field b of someGeneric type definition

I just re checked , generic can't check without instantiating, they will not turns to a node for check. I added a good case , the first generic type will not checked, but it can be used in second type. second one is plain object, it do check its definition.

[bung87]

@Araq tyNone is added in semMagic.

[bung87]

@Araq what else I can do for this?