Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl 3 support (1.6) #20669

Merged
merged 7 commits into from
Nov 2, 2022
Merged

openssl 3 support (1.6) #20669

merged 7 commits into from
Nov 2, 2022

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Oct 26, 2022

#20668 adapted to 1.6, see also #19814, #20324, #20341

@metagn
Copy link
Collaborator Author

metagn commented Oct 27, 2022 •
edited
Loading

CI failure is pre existing since 8e04112 (or c9df6cf or 203c183)

@metagn metagn mentioned this pull request Oct 27, 2022
Merged
@metagn
Copy link
Collaborator Author

metagn commented Oct 31, 2022

Cherry picked #20701 as well

@ringabout
Copy link
Member

ringabout commented Oct 31, 2022 •
edited
Loading

CI failure is pre existing

It should be fixed now mratsim/weave#188

@ringabout ringabout requested review from narimiran and removed request for narimiran November 1, 2022 05:52
@ringabout
Copy link
Member

ringabout commented Nov 1, 2022 •
edited
Loading

Hold on, #20701 is not enough which fixes a part of the issue, I will push a fix for

/home/runner/work/nightlies/nightlies/nim-1.7.3/lib/wrappers/openssl.nim(844, 23) Error: undeclared identifier: 'sslSymNullable'

@ringabout ringabout mentioned this pull request Nov 1, 2022
Merged
@ringabout
Copy link
Member

Here you are #20722

@metagn
Copy link
Collaborator Author

metagn commented Nov 1, 2022

Added

@narimiran narimiran merged commit 121602e into nim-lang:version-1-6 Nov 2, 2022
@metagn metagn mentioned this pull request Nov 3, 2022
Closed
@ehmry ehmry mentioned this pull request Dec 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metagn @ringabout @narimiran