Allow futureLogging in release builds
#21448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Varriount
approved these changes
Mar 2, 2023
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* Add test case * Fixes 21447: Keeps stackTrace around when using futureLogging * Remove extra whitespace
narimiran
pushed a commit
that referenced
this pull request
May 3, 2023
* Add test case * Fixes 21447: Keeps stackTrace around when using futureLogging * Remove extra whitespace (cherry picked from commit d4d28f2)
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
* Add test case * Fixes 21447: Keeps stackTrace around when using futureLogging * Remove extra whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21447
Keeps extra debug information for
FutureBasearound when compiling with-d:futureLogging(Previously only kept it when not building in release)