fixes #21306; fixes #20485; don't transform yields in the var section when introducing new local vars [backport: 1.6] #21489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing new local vars
ringabout
changed the title
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Mar 23, 2023
… when introducing new local vars [backport: 1.6] (#21489) * fixes #21306; don't transform yields in the var section when introducing new local vars * adds `inVarSection` so the var section in the var section is freshed * use `isIntroducingNewLocalVars` to avoid yield transformations in var sections * fixes comments (cherry picked from commit f2dad94)
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
… the var section when introducing new local vars [backport: 1.6] (nim-lang#21489) * fixes nim-lang#21306; don't transform yields in the var section when introducing new local vars * adds `inVarSection` so the var section in the var section is freshed * use `isIntroducingNewLocalVars` to avoid yield transformations in var sections * fixes comments
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
… the var section when introducing new local vars [backport: 1.6] (nim-lang#21489) * fixes nim-lang#21306; don't transform yields in the var section when introducing new local vars * adds `inVarSection` so the var section in the var section is freshed * use `isIntroducingNewLocalVars` to avoid yield transformations in var sections * fixes comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21306
fixes #20485
introduceNewLocalVarsshouldn't transform yields when introducing local variables. It doesn't do for plain yields, namely only transform their children. However it is not the same case for yields in the var sections. We should make it the same as plain yields.reduced cases
Probably it is better to set the inlining to zero when calling
introduceNewLocalVars. They should have the same outcome.