Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to osalloc.nim from commit 8d7a45f. #4853

Merged
merged 1 commit into from
Oct 6, 2016
Merged

Conversation

GaveUp
Copy link
Contributor

@GaveUp GaveUp commented Oct 4, 2016

Change caused MAP_ANONYMOUS to have an incorrect value when compiling
for mipsel.

Fixes #4852.

@dom96
Copy link
Contributor

dom96 commented Oct 4, 2016

You sure it's commit GaveUp@fe2b39f? That doesn't seem to change what you are reverting.

@GaveUp
Copy link
Contributor Author

GaveUp commented Oct 4, 2016

You're right. Copied the parent sha by mistake. Correct one is 8d7a45f

Change caused MAP_ANONYMOUS to have an incorrect value when compiling
for mipsel.

Fixes nim-lang#4852.
@GaveUp GaveUp changed the title Revert change to osalloc.nim from commit fe2b39f. Revert change to osalloc.nim from commit 8d7a45f. Oct 4, 2016
@dom96
Copy link
Contributor

dom96 commented Oct 4, 2016

cc @arnetheduck

@Araq Araq merged commit 0b84eac into nim-lang:devel Oct 6, 2016
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Oct 6, 2016
Fixes build failure on mipsel

Bug: nim-lang/Nim#4853
Reported-by: der@2-47.ru

Package-Manager: portage-2.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants