-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Added {.experimental: "codeReordering".} to manual #8806
Conversation
Something to add wrt {.reorder: on.}
proc x() =
echo(declared(foo))
var foo = 4
x() # "false", the same as it would be with {.reorder: off.} Should this be defined behavior (in which case I will clarify in the docs) or is this an issue? |
The last time I thought about it, it seems to break less code the way it's handled now. |
Ok, but shouldn't this become |
doc/manual.rst
Outdated
``nim check`` provides this option as well. | ||
|
||
Example: | ||
NOTE: The following was documentation for the precursor to {.reorder.}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just remove this? It's just a distraction to keep it there I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hidden at the moment, right? I'm still in favor of noforward
as a more comprehensive solution and I hope to work on it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's commented out in case it becomes relevant again. (if you really really want me to I'll remove it)
Changed the stuff to If we're going with #8875, please merge that before/same time as this. |
Closes #8699.
Might also for #8822. (depends on if {.reorder.} needs new impl)