Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc does not take untyped/typed as argument #9981

Merged
merged 2 commits into from
Dec 19, 2018
Merged

proc does not take untyped/typed as argument #9981

merged 2 commits into from
Dec 19, 2018

Conversation

nc-x
Copy link
Contributor

@nc-x nc-x commented Dec 14, 2018 •
edited
Loading

Fixes #6970
Fixes #7469
Closes #9669
Fixes #9593

@nc-x
Copy link
Contributor Author

nc-x commented Dec 16, 2018

Ready for review.

@Araq
Copy link
Member

Araq commented Dec 19, 2018

Much simpler logic:

if owner.kind != skModule or owner.owner.name.s != "stdlib"

@nc-x
Copy link
Contributor Author

nc-x commented Dec 19, 2018

Done.

krux02
krux02 approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@krux02 krux02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@Araq Araq added the merge_when_passes_CI mergeable once green label Dec 19, 2018
@Araq Araq merged commit 730b1b2 into nim-lang:devel Dec 19, 2018
@nc-x nc-x deleted the typed-untyped-proc branch December 27, 2018 13:37
@nc-x nc-x mentioned this pull request Jan 11, 2019
Closed
@krux02
Copy link
Contributor

krux02 commented Jan 11, 2019

I just checked if the current development branch detects all examples that I had, and this one is still uncaught with your PR:

proc bar(): untyped =
  discard

Will you come up with another fix for that?

@nc-x nc-x mentioned this pull request Jan 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 left review comments

@krux02 krux02 krux02 approved these changes

Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nc-x @Araq @krux02 @dom96