Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression: invalid proc quit()* => proc quit*() #110

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

timotheecour
Copy link
Member

/cc @krux02
fixes regression introduced in d0537fc

@timotheecour timotheecour changed the title fix invalid proc quit()* => proc quit*() fix regression: invalid proc quit()* => proc quit*() Nov 7, 2018
@yglukhov yglukhov merged commit f1f2d14 into nim-lang:master Nov 7, 2018
@timotheecour timotheecour deleted the pr_fix_quit_export branch November 7, 2018 20:09
@krux02
Copy link
Contributor

krux02 commented Nov 7, 2018

oh, sorry. Really I should have noticed it. And actually I did notice it, but because of git branch hell that update got lost. But thanks for the quick fix.

@timotheecour
Copy link
Member Author

sure; but the "proper" fix would really be #111

@krux02
Copy link
Contributor

krux02 commented Nov 7, 2018

no the proper thing would be to run the examples. And I did, but I had a lost update due to branch confusion. I didn't realize that the correct thing was overridden by the wrong thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants