[superseded] bump version 2.1 (please aslo create a git tag) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is so that clients can refer to requires "sdl2 >= 2.1" see also yglukhov/nimx#344
|
sorry I won't update the version over the version of the original sdl2 library. I see the last release as a failed release |
|
I have just re-released the v2.0 version. It was not usable anyway, so there's nothing to lose. |
|
@yglukhov thanks |
timotheecour
changed the title
|
superseded by #114 |
timotheecour
added a commit
to timotheecour/sdl2
that referenced
this pull request
Nov 8, 2018
…t 2.0 the forced-pushed again at 2.0 after new commits) rationale: see comment from @Araq here: nim-lang#113 (comment) > The Nimble version shouldn't be based on the version of the originally wrapped library, that ignores how the Nim wrapping mechanism works. Only accessed symbols are dlsym'ed so wrapping SDL 2.0.10 and accessing a SDL_2.0.1.dll works as long as you don't use a feature that 2.0.1 lacks. supersedes nim-lang#112 and nim-lang#113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @krux02 @yglukhov
this is so that clients can refer to
requires "sdl2 >= 2.1"
see also yglukhov/nimx#344
(unless you guys have a better way for that?)