Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove new project folder if new_project.kts fails #433

Closed
toby-thanathip opened this issue Mar 8, 2023 · 0 comments · Fixed by #469
Closed

Remove new project folder if new_project.kts fails #433

toby-thanathip opened this issue Mar 8, 2023 · 0 comments · Fixed by #469
Assignees
@ryan-conway
Labels
priority : normal status : approved type : feature
Milestone
3.21.0

Comments

@toby-thanathip
Copy link
Contributor

toby-thanathip commented Mar 8, 2023 •
edited
Loading

RFC: #268

Why

When running new_project.kts, it runs a series of steps to generate a new project.

Let's say one of the steps failed, then the new project folder is currently not removed.

This gives the user the wrong impression that the generated project is safe to use.

Acceptance Criteria

  • Remove the generated project automatically, if an error occurred during the script execution
  • Add a new argument force=true (false by default), to optionally force the generation even though there's an error.
  • Update README.md & helpMessage inside new_project.kts

Who Benefits?

Users of the template will be less confused in case the project generation failed.
@ryan-conway ryan-conway added this to the 3.19.0 milestone Mar 8, 2023
@ryan-conway ryan-conway modified the milestones: 3.19.0, 3.20.0 Apr 4, 2023
@ryan-conway ryan-conway self-assigned this May 2, 2023
ryan-conway added a commit that referenced this issue May 19, 2023
@ryan-conway
[#433] Add force argument
8ec8185
ryan-conway added a commit that referenced this issue May 19, 2023
@ryan-conway
[#433] Delete generated project on error if forceProjectCreation is f…
221a012 
…alse
ryan-conway added a commit that referenced this issue May 19, 2023
@ryan-conway
[#433] Add force argument
15301ff
ryan-conway added a commit that referenced this issue May 19, 2023
@ryan-conway
[#433] Delete generated project on error if forceProjectCreation is f…
fccb703 
…alse
@ryan-conway ryan-conway mentioned this issue May 19, 2023
Merged
ryan-conway added a commit that referenced this issue May 19, 2023
@ryan-conway
[#433] Update README with force argument
2939d2e
@ryan-conway ryan-conway linked a pull request May 19, 2023 that will close this issue
[#433] Remove new project folder if new_project.kts fails #469
Merged
@ryan-conway ryan-conway modified the milestones: 3.20.0, 3.21.0 Jun 1, 2023
ryan-conway added a commit that referenced this issue Jun 16, 2023
@ryan-conway
Merge pull request #469 from nimblehq/chore/433-remove-new-project-fo…
53958f2 
…lder-if-new_projectkts-fails

[#433] Remove new project folder if `new_project.kts` fails
@ryan-conway ryan-conway mentioned this issue Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan-conway ryan-conway

Labels
priority : normal status : approved type : feature
Projects
None yet
Milestone
3.21.0
Development

Successfully merging a pull request may close this issue.

[#433] Remove new project folder if new_project.kts fails nimblehq/android-templates
2 participants
@toby-thanathip @ryan-conway