Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add red cross emoji to error messages when new_project.kts fails #437

Closed
ryan-conway opened this issue Mar 9, 2023 · 0 comments · Fixed by #468
Closed

Add red cross emoji to error messages when new_project.kts fails #437

ryan-conway opened this issue Mar 9, 2023 · 0 comments · Fixed by #468
Assignees
@ryan-conway
Labels
priority : normal status : approved type : chore
Milestone
3.20.0

Comments

@ryan-conway
Copy link
Collaborator

Why

Original RFC

When one of the steps in new_project.kts fails, it will print an error message. However, this error message may not be too obvious to the user and could be unintentionally ignored.

To fix this, we should add a more obvious indicator that something has failed

Who Benefits?

Android developers

Acceptance Criteria

  • Add a cross emoji ( ❌ ) to the beginning of the error messages printed when new_project.kts fails
    • For example: ❌ Error: Invalid Package Name
@ryan-conway ryan-conway added this to the 3.19.0 milestone Mar 9, 2023
@ryan-conway ryan-conway modified the milestones: 3.19.0, 3.20.0 Apr 4, 2023
@ryan-conway ryan-conway self-assigned this May 10, 2023
ryan-conway added a commit that referenced this issue May 19, 2023
@ryan-conway
[#437] Add cross emoji to script error messages
47f50be
@ryan-conway ryan-conway mentioned this issue May 19, 2023
Merged
ryan-conway added a commit that referenced this issue May 19, 2023
@ryan-conway
[#437] Add cross emoji to script error messages
da7e1c4
ryan-conway added a commit that referenced this issue May 30, 2023
@ryan-conway
Merge pull request #468 from nimblehq/chore/437-add-red-cross-emoji-t…
31e1269 
…o-error-messages-when-new_projectkts-fails

[#437] Add red cross emoji to error messages when new_project.kts fails
@ryan-conway ryan-conway mentioned this issue Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan-conway ryan-conway

Labels
priority : normal status : approved type : chore
Projects
None yet
Milestone
3.20.0
Development

Successfully merging a pull request may close this issue.

[#437] Add red cross emoji to error messages when new_project.kts fails nimblehq/android-templates
1 participant
@ryan-conway