Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove Firebase integration in order to generate new project from the script #496

Closed
lydiasama opened this issue Aug 2, 2023 · 0 comments · Fixed by #499
Closed

Comments

@lydiasama
Copy link
Contributor

Issue

When generateing the project from the script, it requires the google-services.json file which we saved in the Github Secrets. To support general users outside Nimble, we need to remove it to make the script can be built successfully without the Firebase integration. Besides, Codemagic supports distributing the app to Firebase App Distribution without integrating the Firebase to the project.

Expected

The generate new project script can run successfully.

@lydiasama lydiasama self-assigned this Aug 2, 2023
@ryan-conway ryan-conway added this to the 3.22.1 milestone Aug 3, 2023
lydiasama added a commit that referenced this issue Aug 15, 2023
lydiasama added a commit that referenced this issue Aug 15, 2023
ryan-conway added a commit that referenced this issue Aug 17, 2023
…t-firebase-integration

[#496] Distribute app without Firebase integration
@ryan-conway ryan-conway modified the milestones: 3.22.1, 3.23.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants