Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Checkout" step in "bump_version" workflow does not need to set a custom token #500

Closed
luongvo opened this issue Aug 3, 2023 · 0 comments · Fixed by #532
Closed

The "Checkout" step in "bump_version" workflow does not need to set a custom token #500

luongvo opened this issue Aug 3, 2023 · 0 comments · Fixed by #532
Assignees
@ryan-conway
Labels
priority : normal status : need voting type : chore
Milestone
3.25.0

Comments

@luongvo
Copy link
Member

luongvo commented Aug 3, 2023

Why

The Checkout step in the bump_version workflow does not need to set a custom token.

android-templates/.github/workflows/bump_version.yml

Lines 18 to 19 in c6cc06d

with:
token: ${{ secrets.GITHUB_TOKEN }}

android-templates/.cicdtemplate/.github/workflows/bump_version.yml

Lines 18 to 19 in c6cc06d

with:
token: ${{ secrets.GITHUB_TOKEN }}

Who Benefits?

Developers
@ryan-conway ryan-conway added this to the 3.24.0 milestone Aug 22, 2023
@ryan-conway ryan-conway modified the milestones: 3.24.0, 3.25.0 Aug 30, 2023
@ryan-conway ryan-conway self-assigned this Oct 5, 2023
ryan-conway added a commit that referenced this issue Oct 6, 2023
@ryan-conway
[#500] Remove unnecessary token from checkout action
0e49800
ryan-conway added a commit that referenced this issue Oct 6, 2023
@ryan-conway
[#500] Update checkout action version and name for consistency
031ff62
@ryan-conway ryan-conway mentioned this issue Oct 6, 2023
Merged
ryan-conway added a commit that referenced this issue Oct 6, 2023
@ryan-conway
Merge pull request #532 from nimblehq/chore/500-the-checkout-step-in-…
cbfa993 
…bump_version-workflow-does-not-need-to-set-a-custom-token

[#500] The "Checkout" step in "bump_version" workflow does not need to set a custom token
@ryan-conway ryan-conway mentioned this issue Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan-conway ryan-conway

Labels
priority : normal status : need voting type : chore
Projects
None yet
Milestone
3.25.0
2 participants
@luongvo @ryan-conway