Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the github workflow #125

Closed
rosle opened this issue Sep 8, 2022 · 0 comments · Fixed by #126
Closed

Improve the github workflow #125

rosle opened this issue Sep 8, 2022 · 0 comments · Fixed by #126
Assignees
@rosle
Labels
type : chore
Milestone
3.1.0

Comments

@rosle
Copy link
Contributor

rosle commented Sep 8, 2022

Why

  • Some steps are missing the step name
  • Remove branch master as I think we always go with main for all the projects
  • Update ubuntu on deployment workflow to use ubuntu-latest, with this we could avoid a deprecated environment message.

The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

I think it should be fine since we're testing with ubuntu latest as well 🤔

Who Benefits?

The template users 🥳
@rosle rosle self-assigned this Sep 8, 2022
rosle added a commit that referenced this issue Sep 8, 2022
@rosle
[#125] Improve github workflow
935874c
@rosle rosle mentioned this issue Sep 8, 2022
Merged
@rosle rosle linked a pull request Sep 8, 2022 that will close this issue
[#125] Improve github workflow #126
Merged
rosle added a commit that referenced this issue Sep 8, 2022
@rosle
[#125] Remove unused Danger plugins
ed1bccc
rosle added a commit that referenced this issue Sep 9, 2022
@rosle
[#125] Update Github actions
39d1b1a
carryall added a commit that referenced this issue Sep 9, 2022
@carryall
Merge pull request #126 from nimblehq/chore/125-improve-workflow
0eb31a0 
[#125] Improve github workflow
@carryall carryall added this to the 3.1.0 milestone Sep 9, 2022
carryall pushed a commit that referenced this issue Oct 2, 2022
@rosle @carryall
[#125] Improve github workflow
d2241f3
carryall pushed a commit that referenced this issue Oct 2, 2022
@rosle @carryall
[#125] Update Github actions
678ab72
@carryall carryall mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosle rosle

Labels
type : chore
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

[#125] Improve github workflow nimblehq/react-templates
2 participants
@carryall @rosle