Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React-query and poap fix #240

Merged
merged 26 commits into from
Dec 17, 2022
Merged

React-query and poap fix #240

merged 26 commits into from
Dec 17, 2022

Conversation

Mi-Lan
Copy link
Collaborator

@Mi-Lan Mi-Lan commented Dec 13, 2022 •
edited
Loading

  • Fixed the ordering of poap themes and default theme
  • Added react-query dependant queries for the initialNimiData
  • Cleaned up ensCard and implemented react-query for the data fetching
  • fixed useEnsMetadata hook so that it returns the image

@vercel
Copy link

vercel bot commented Dec 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nimi-io-app-development ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 3:54PM (UTC)
nimi-io-app-production ✅ Ready (Inspect) Visit Preview Dec 17, 2022 at 3:54PM (UTC)

@Mi-Lan Mi-Lan changed the title Paop themes WIP:Paop themes Dec 13, 2022
@Mi-Lan Mi-Lan changed the title WIP:Paop themes React-query and poap fix Dec 14, 2022
@Mi-Lan Mi-Lan requested a review from b8zeek December 16, 2022 14:51
b8zeek
b8zeek approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@b8zeek b8zeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Good job @Mi-Lan.

@adamazad, let's try to merge this today, let's be more up-to-date with these PRs in order not to block the development. Even if there are small things that might be changed, I would prefer speed at this point.

src/api/RestAPI/hooks/useEnsGeneratedData.ts Outdated Show resolved Hide resolved
src/api/RestAPI/hooks/useEnsGeneratedData.ts Outdated Show resolved Hide resolved
src/components/ENSCard/ENSCardContainer/ENSCardContainer.tsx Show resolved Hide resolved
src/hooks/useDefaultNimiData.ts Show resolved Hide resolved
src/hooks/useDefaultNimiData.ts Show resolved Hide resolved
@Mi-Lan Mi-Lan requested a review from adamazad December 16, 2022 19:36
@Mi-Lan Mi-Lan merged commit d3e8a7a into development Dec 17, 2022
@Mi-Lan Mi-Lan self-assigned this Dec 19, 2022
This was referenced Dec 26, 2022
Closed
Closed
@adamazad adamazad deleted the fix/paop-theme branch January 4, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamazad adamazad adamazad approved these changes

@b8zeek b8zeek b8zeek approved these changes

Assignees

@Mi-Lan Mi-Lan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mi-Lan @adamazad @b8zeek