Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tests for Accounts/AccountsTree class #32

Closed
styppo opened this issue May 17, 2017 · 0 comments
Closed

Create tests for Accounts/AccountsTree class #32

styppo opened this issue May 17, 2017 · 0 comments
Labels
testing
Milestone
DemoNet

Comments

@styppo
Copy link
Member

styppo commented May 17, 2017 •
edited
Loading

There are already a couple of Accounts/AccountsTree tests to start with:
https://github.com/nimiq-network/core/tree/master/src/test/specs/generic/consensus/accounts

Accounts: e.g.

  • complex blocks
  • invalid blocks

AccountsTree: e.g.

  • deep trees
  • large trees
  • persistent storage (?)
@styppo styppo added the testing label May 17, 2017
@styppo styppo added this to the DemoNet milestone May 18, 2017
schrnz added a commit that referenced this issue May 29, 2017
@schrnz
Additional (smaller) tests for AccountsTree, Address and Balance. Ref #…
8228b0d 
…32
schrnz added a commit that referenced this issue Jun 12, 2017
@schrnz
Smaller tests for AccountsTree and Balance. Ref #32
04a7004
schrnz added a commit that referenced this issue Jun 12, 2017
@schrnz
Tests for Accounts spec, ref #32
d5ed6aa 
Minor note: There is a test for self-transmissions that currently fails.
This test is deactivated (`xit`) b/c this is already enforced in the blockchain (but not in Accounts).
If we want to test this/move the check to Accounts, this test can be used.
schrnz added a commit that referenced this issue Jun 13, 2017
@schrnz
Test to reproduce issue #161 (also ref #32)
ce7c4cf
schrnz added a commit that referenced this issue Jun 13, 2017
@schrnz
Retrofitting AccountsTree tests for parameterized execution, ref #32
829721e 
All tests are executed for each provided type of accounts tree.
TODO: As soon as issue #161 is fixed, 'persistent' (and potantially also 'temporary persistent') can be added to the list so that the tests are invoked automatically in those cases, too.
@schrnz schrnz mentioned this issue Jun 19, 2017
Merged
schrnz added a commit that referenced this issue Jun 19, 2017
@schrnz
Excluding long-running test to make firefox test pass, ref #32
3ea13dd
schrnz added a commit that referenced this issue Jun 27, 2017
@schrnz
AccTree: Huge test for adding and removing nodes to the underlying st…
433256a 
…ore (ref #32)

* Also added equals method to AccountTreeNode that compares its values since jasmine's toEqual fails if the hash is cached for one node but not for the other.
@paberr paberr closed this as completed in 9adb70b Jul 1, 2017
paberr pushed a commit that referenced this issue Jul 14, 2017
@schrnz
Retrofitting AccountsTree tests for parameterized execution, ref #32
6177da4 
All tests are executed for each provided type of accounts tree.
TODO: As soon as issue #161 is fixed, 'persistent' (and potantially also 'temporary persistent') can be added to the list so that the tests are invoked automatically in those cases, too.
paberr pushed a commit that referenced this issue Jul 14, 2017
@schrnz
Tests for wide and deep account trees and the export functionality, c…
6e4dcd0 
…lose #32

Note on the export API: As explained in issue #172, the import API is missing. Hence the corresponding export tests are incomplete.
paberr pushed a commit that referenced this issue Jul 14, 2017
@schrnz
Excluding long-running test to make firefox test pass, ref #32
314144d
paberr pushed a commit that referenced this issue Jul 14, 2017
@schrnz
AccTree: Huge test for adding and removing nodes to the underlying st…
e323f96 
…ore (ref #32)

* Also added equals method to AccountTreeNode that compares its values since jasmine's toEqual fails if the hash is cached for one node but not for the other.
paberr pushed a commit that referenced this issue Jul 14, 2017
@schrnz
Test to reproduce issue #161 (also ref #32)
ec71a97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
DemoNet
Development

No branches or pull requests
2 participants
@styppo @schrnz